Re: windows consolidated cleanup

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Andrew Chernow <ac(at)esilo(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: windows consolidated cleanup
Date: 2011-04-24 21:10:16
Message-ID: 17613.1303679416@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 04/24/2011 09:11 AM, Andrew Chernow wrote:
>> The macro is overriding the prototype declared at line 627, which has
>> a void argument list (assuming YY_SKIP_YYWRAP is !defined). Since all
>> code references to this do not provide an argument, I'd say the macro
>> is incorrect.

> Here's the fix that worked for me:

Could we please make this conditional on seeing "%option reentrant" in
the .l file, instead of hard-wiring an assumption about which scanners
are re-entrant?

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-04-24 21:27:50 Re: Unlogged tables, persistent kind
Previous Message Andrew Dunstan 2011-04-24 19:40:25 Re: windows consolidated cleanup