mha(at)postgresql(dot)org (Magnus Hagander) writes:
> Fix strftime usage on Win32 when trying to fetch the locale-aware
> parts of a time string so it properly handles different encodings.
Hmm, this patch has
+ wchar_t wbuf[MAX_L10N_DATA];
+
+ len = wcsftime(wbuf, sizeof(wbuf), format, tm);
The Single Unix Spec's definition of wcsftime says that the above
risks a buffer overrun, and the correct second argument would be
MAX_L10N_DATA. Now I realize that SUS is a poor guide for
Windows-specific code, but are you sure this is right?
Also, I believe we've deprecated StrNCpy; use strlcpy if possible.
regards, tom lane