Skip site navigation (1) Skip section navigation (2)

rbtree code breaks GIN's adherence to maintenance_work_mem

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: rbtree code breaks GIN's adherence to maintenance_work_mem
Date: 2010-07-31 04:40:03
Message-ID: 17478.1280551203@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Another misbehavior that I noted while playing with Artur's example is
that, while GIN index build seems to adhere pretty well to whatever
maintenance_work_mem limit you give it in 8.4, it blows right by that
limit in 9.0 and HEAD --- I observed it happily eating something north
of 128MB with a maintenance_work_mem of 70MB.  It looks to me like the
reason is the new "rbtree.c" code, which adds a whole lot of data
structure that's not being counted against the maintenance_work_mem
limit.

Now the first question that might be asked is what we'd need to do to
rbtree.c's API to allow its memory consumption to be tracked.  However,
I think there's a considerably more pressing question, which is what
is it that rbtree.c is doing that justifies a 2X bloat factor in GIN
index build --- which is pretty much what it's costing us, given the
observation above.  We know that the amount of memory available for
the build has an enormous effect on build time.  If we just do the
obvious thing of including the rbtree data structure in the
maintenance_work_mem calculation, what we're going to get is a very
substantial slowdown in build speed for the same maintenance_work_mem
setting, compared to the way 8.4 worked.

So, I would like somebody to show cause why that whole module shouldn't
be ripped out and the code reverted to where it was in 8.4.  My
recollection is that the argument for adding it was to speed things up
in corner cases, but what I think it's actually going to do is slow
things down in every case.

			regards, tom lane

Responses

pgsql-hackers by date

Next:From: Stephen FrostDate: 2010-07-31 11:08:14
Subject: Re: ANALYZE versus expression indexes with nondefaultopckeytype
Previous:From: Tom LaneDate: 2010-07-31 03:53:26
Subject: ANALYZE versus expression indexes with nondefault opckeytype

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group