Re: MV patch broke users of ExplainOneQuery_hook

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Kevin Grittner <kgrittn(at)ymail(dot)com>
Subject: Re: MV patch broke users of ExplainOneQuery_hook
Date: 2013-04-09 14:33:37
Message-ID: 17072.1365518017@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Tue, Apr 9, 2013 at 10:25 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> TBH I'd like to revert all of that anyway; it seemed to me to be
>> basically gratuitous breakage of an API used by plugins. I've not
>> had time to look at whether there was an actual reason for it and
>> if so how we might solve that differently.

> Oops. I just pushed a fix for the situation as it stands, but it's
> only 2 lines, so it shouldn't be too much trouble to revert it if we
> decide on a different approach. I do agree it would be nice not to
> need to change the API there.

If we don't revert then what you pushed is clearly necessary, so
no objection to having done that. I'll look at the larger situation
as soon as I get a chance.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message th 2013-04-09 15:01:33 BUG #8049: Incorrect results when using ORDER BY and query planner options
Previous Message Robert Haas 2013-04-09 14:28:53 Re: MV patch broke users of ExplainOneQuery_hook