pgindent vs try/catch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: pgindent vs try/catch
Date: 2004-09-12 17:40:02
Message-ID: 17028.1095010802@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I'm fairly displeased with what pgindent has done to single-line PG_TRY
constructs, as in this example from pl_exec.c:

*************** exec_stmt_block(PLpgSQL_execstate * esta
*** 911,922 ****
SPI_result_code_string(xrc));

PG_TRY();
! {
! rc = exec_stmts(estate, block->body);
! }
PG_CATCH();
{
! ErrorData *edata;
PLpgSQL_exceptions *exceptions;
int j;

--- 912,921 ----
SPI_result_code_string(xrc));

PG_TRY();
! rc = exec_stmts(estate, block->body);
PG_CATCH();
{
! ErrorData *edata;
PLpgSQL_exceptions *exceptions;
int j;

*************** exec_stmt_block(PLpgSQL_execstate * esta

On the whole I'd prefer that pgindent not suppress "unnecessary"
brace pairs at all.

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gaetano Mendola 2004-09-12 18:40:36 security definer on views
Previous Message Tom Lane 2004-09-12 16:50:28 Re: beta1 & beta2 & Windows & heavy load