Skip site navigation (1) Skip section navigation (2)

Re: Correction of how to use TimeZone by ControlFile(xlog.c)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Gregory Stark <stark(at)enterprisedb(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Correction of how to use TimeZone by ControlFile(xlog.c)
Date: 2007-08-03 19:34:35
Message-ID: 1670.1186169675@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Tom's idea of a log_timezone seems to make sense.

Here's a preliminary patch for this --- no docs yet, but code is all
there.  Seems to work OK.  The patch is larger than it'd really have to
be because I chose to rename global_timezone to session_timezone;
I thought it'd be confusing to have something called "global_timezone"
that actually has a narrower scope than "log_timezone".

This wouldn't do for backpatching of course.  My inclination for a
backpatch is to just take %Z out of the strftime formats for Windows,
as we did in several places already.

Comments?

			regards, tom lane


Attachment: log_timezone_1.patch.gz
Description: application/octet-stream (6.4 KB)

In response to

Responses

pgsql-patches by date

Next:From: Simon RiggsDate: 2007-08-03 20:37:43
Subject: Re: Async Commit, v21 (now: v22)
Previous:From: Magnus HaganderDate: 2007-08-03 18:40:23
Subject: Re: Correction of how to use TimeZone by ControlFile(xlog.c)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group