Re: Async Commit, v21 (now: v22)

From: "Simon Riggs" <simon(at)2ndquadrant(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Async Commit, v21 (now: v22)
Date: 2007-08-03 20:37:43
Message-ID: 1186173463.4136.27.camel@ebony.site
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Wed, 2007-08-01 at 18:54 -0400, Tom Lane wrote:
> "Simon Riggs" <simon(at)2ndquadrant(dot)com> writes:
> > Here's v23, including all suggested changes, plus some reworking of the
> > transaction APIs to reduce the footprint of the patch.
>
> Applied with some editorialization ---

Thanks

> I found a few bugs, as well as
> things that seemed they could be neater.

Keen to improve: any chance of explaining, possibly offlist?

> Notable was that the patch
> would have significantly increased the contention for CLogControlLock by
> requiring two lock cycles to fetch a transaction's commit status and
> LSN. I changed it so that TransactionIdGetStatus returns both pieces
> of information.

Thanks for picking that up.

--
Simon Riggs
EnterpriseDB http://www.enterprisedb.com

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Decibel! 2007-08-03 23:12:09 Re: Repair cosmetic damage (done by pg_indent?)
Previous Message Tom Lane 2007-08-03 19:34:35 Re: Correction of how to use TimeZone by ControlFile(xlog.c)