Re: fix - function call with variadic parameter for type "any"

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: fix - function call with variadic parameter for type "any"
Date: 2009-04-02 20:23:13
Message-ID: 162867790904021323l6f13dca1u48cc9bb93d20d2c3@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2009/4/2 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
> Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
>> Our implementation of variadic parameters are not complete. The
>> support of "any" type is incomplete. Modificator VARIADIC for funccall
>> parameters needs transformation from ArrayExpr to standard parameters
>> list.
>
> I don't think I agree with this change.  The point of an ANY function
> is that the function is going to do its own coping with the presented
> arguments.  This patch takes away the flexibility to do that and instead
> enforces one very restrictive view of what the intended behavior is.

ok, but then an function have to be noticed about using VARIADIC
parameter's modificator.

actually, there isn't any difference between a) and b)

a) select somevariadicwithany(10);
b) select somevariadicwithany(variadic 10);

in this case the keyword VARIADIC is ignored.

regards
Pavel Stehule

>
>                        regards, tom lane
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2009-04-02 20:32:56 Re: [COMMITTERS] pgsql: If we expect a hash join to be performed in multiple batches,
Previous Message Robert Haas 2009-04-02 20:07:04 Re: [HACKERS] Mentors needed urgently for SoC & PostgreSQL Student Internships