Re: trivial fix in fd.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Qingqing Zhou" <zhouqq(at)cs(dot)toronto(dot)edu>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: trivial fix in fd.c
Date: 2006-05-22 14:52:04
Message-ID: 16274.1148309524@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

"Qingqing Zhou" <zhouqq(at)cs(dot)toronto(dot)edu> writes:
> What's the rationale of designing resowner
> APIs like this:

> ResourceOwnerEnlargeABC();
> ResourceOwnerRememberABC();

> Is that because sometimes we don't allow any elog in
> ResourceOwnerRememberABC()?

Yeah. In a number of cases, ResourceOwnerRememberABC is done after
inserting the resource into some data structure, and an elog there
would leave the data structure in an inconsistent state. Conversely,
we might fail to insert the resource into the other data structure,
so just inserting it into the resowner first isn't better.

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2006-05-22 15:23:19 Re: Duplicate definition of LOCALEDIR
Previous Message Martijn van Oosterhout 2006-05-22 12:39:04 Re: Duplicate definition of LOCALEDIR