Re: WIP: fix SET WITHOUT OIDS, add SET WITH OIDS

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Marko Kreen <markokr(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, David Fetter <david(at)fetter(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: WIP: fix SET WITHOUT OIDS, add SET WITH OIDS
Date: 2009-02-09 16:32:23
Message-ID: 16263.1234197143@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Heikki Linnakangas wrote:
>> Andrew Dunstan wrote:
>>> How about a pg_dump flag that simply suppresses OIDs from the data
>>> and schema?
>>
>> pg_dump -s postgres | sed -e 's/SET default_with_oids = true;/-- &/'

> No good for non-text dumps.

Also it would fail badly if the dump had in fact been made with -o.

Currently there are two behaviors in pg_dump:

1. With -o: preserve both the existence of oid columns and their
exact contents

2. Without -o: preserve the existence of oid columns, but don't
worry about duplicating their contents (default).

It might be worth extending the switch to provide a third option
to get rid of oid columns altogether, but I'm really not convinced
that this is better than suggesting that people run ALTER SET WITHOUT
OIDS on all their tables.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2009-02-09 16:32:51 Re: WIP: fix SET WITHOUT OIDS, add SET WITH OIDS
Previous Message Heikki Linnakangas 2009-02-09 16:26:15 Re: WIP: fix SET WITHOUT OIDS, add SET WITH OIDS