From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits. |
Date: | 2016-10-12 15:36:17 |
Message-ID: | 16063.1476286577@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 10/4/16 11:29 AM, Tom Lane wrote:
>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>> Apparently, 'make world' does not build worker_spi. I thought 'make
>>> world' was supposed to build everything?
>> You'd have thunk, yeah. It looks like the issue is that src/Makefile
>> is selective about recursing into certain subdirectories of test/,
>> but mostly not test/ itself. src/test/Makefile naively believes it's
>> in charge, though. Probably that logic ought to get shoved down one
>> level, and then adjusted so that src/test/modules gets built by "all".
>> Or else teach top-level "make world" to do "make all" in src/test/,
>> but that seems like it's just doubling down on confusing interconnections.
> We generally don't build test code during make world.
> The reason src/Makefile does that is probably because pg_regress is part
> of the installation.
> So this looks more or less correct to me.
Even if you think the behavior is correct (I'm not convinced), the
implementation is certainly confusing. I don't like the way that
src/test/Makefile gets bypassed for decisions about which of its
subdirectories get built for what. Any normal person would expect
that src/test/Makefile is what determines that.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2016-10-12 16:04:35 | Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits. |
Previous Message | Peter Eisentraut | 2016-10-12 15:18:57 | Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits. |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-10-12 15:40:55 | Re: Non-empty default log_line_prefix |
Previous Message | Stephen Frost | 2016-10-12 15:31:49 | Re: Renaming of pg_xlog and pg_clog |