Re: Win32 timezone matching

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Win32 timezone matching
Date: 2010-04-07 15:57:44
Message-ID: 15945.1270655864@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc> writes:
> hmm all that code makes me wonder a bit about a more general issue - is
> the "fallback to GMT if we fail to actually make sense of the right
> imezone to use" actually a good idea?

What alternative are you proposing? Failing to start the server doesn't
seem like an attractive choice.

> I would consider the failure to make sense of the registry on windows or
> failure to figure timezone information out a more serious issue than a
> mere "WARNING" because depending on how you look at the issue it might
> actually cause silent data corruption.

Somehow, if you're running a database on windoze, I doubt your data
integrity standards are that high. In any case I'd rather get a bleat
about "why is the server running in GMT" than "my database won't start".
The former will be a lot easier to narrow down.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2010-04-07 16:07:42 Re: pgsql: Forbid using pg_xlogfile_name() and pg_xlogfile_name_offset()
Previous Message Stefan Kaltenbrunner 2010-04-07 15:51:30 Re: Win32 timezone matching