Re: Patching for increasing the number of columns

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Mayeul Kauffmann <mayeul(dot)kauffmann(at)free(dot)fr>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Patching for increasing the number of columns
Date: 2014-08-20 15:56:48
Message-ID: 15886.1408550208@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Mayeul Kauffmann <mayeul(dot)kauffmann(at)free(dot)fr> writes:
> I am trying to patch the server source to increase the number of columns
> above 1600. I'm not planning to commit this but as suggested elsewhere
> [1], someone might suggest a configure option based on this.
> I came up with a patch which seems to work (see below), but 3 of the 136
> tests fail.

You would have to show us the actual failure diffs to get much useful
comment, but in general increasing the size of tuple headers could
easily lead to changes in plan choices, which would affect output
row ordering (not to mention EXPLAIN results). This is particularly
the case if you're testing on a 64-bit machine, since the maxalign'd
size of the header would go from 24 to 32 bytes ...

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabrízio de Royes Mello 2014-08-20 16:02:03 Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED
Previous Message David Fetter 2014-08-20 15:50:18 Re: Patch status: delta relations in AFTER triggers