| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Joe Conway <mail(at)joeconway(dot)com> |
| Cc: | Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: dblink memory leak |
| Date: | 2009-10-05 18:53:24 |
| Message-ID: | 15846.1254768804@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Joe Conway <mail(at)joeconway(dot)com> writes:
> Given that change, is there even any leak to even worry about? As long
> as the PGresult object is created in the correct memory context, it
> ought to get cleaned up automatically, no?
No, because libpq knows nothing of backend memory contexts; it just
allocates with malloc. You'll still need a PG_TRY block to ensure you
release PGresults during error cleanup. The change to using tuplestores
will just help you localize that requirement in well-defined places.
> I can't promise to make this change before 15 October, but I will get to
> it before the end of CF3.
No big hurry, I think, considering the leak has always been there.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Berkus | 2009-10-05 18:58:20 | Re: Privileges and inheritance |
| Previous Message | Simon Riggs | 2009-10-05 18:49:49 | Re: Hot Standby on git |