Re: Case Conversion Functions

Volkan YAZICI <yazicivo(at)ttnet(dot)net(dot)tr> writes:
> There're lots of places in the code which uses either pg_tolower()
> or just tolower() - without aware of MB characters; or some
> on-their-own implementations of pg_tolower(). (Actually, AFAIK,
> whole MB case conversion is broken in -rHEAD.)

The upper/lower functions themselves work AFAIK, but I agree that stuff
like ILIKE probably is broken for MB encodings. regex character classes
need help too.

> Another example:
> backend/parser/scansup.c
> 152 else if (ch >= 0x80 && isupper(ch))
> 153 ch = tolower(ch);

Fooling with that is fairly risky --- we've been burnt before by
locale-dependent case folding of SQL identifiers. In particular
it'd be really bad if the folding could change on-the-fly at runtime.

regards, tom lane