Re: pgsql: Do all accesses to shared buffer headers through

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Do all accesses to shared buffer headers through
Date: 2005-10-13 00:27:32
Message-ID: 15672.1129163252@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Neil Conway <neilc(at)samurai(dot)com> writes:
> IMHO it is notationally clearer to define a "BufferDescPtr" that
> contains the "volatile" qualifier than to make sure that "volatile" is
> used everywhere that it is needed -- obviously, neither approach is
> fool-proof. But perhaps that's just me...

Personally I dislike hiding type qualifiers like const and volatile
inside typedefs. I agree it's a judgment call.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message User Aglio 2005-10-13 00:39:48 press - pr: Final edits in preparation for translation.
Previous Message Tom Lane 2005-10-13 00:06:47 pgsql: Don't try to remove duplicate OR-subclauses in

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2005-10-13 00:33:01 Re: Comments on columns in the pg_catalog tables/views
Previous Message Neil Conway 2005-10-12 23:36:30 Re: pgsql: Do all accesses to shared buffer headers