Re: is there a deep unyielding reason to limit U&'' literals to ASCII?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Chapman Flack <chap(at)anastigmatix(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: is there a deep unyielding reason to limit U&'' literals to ASCII?
Date: 2016-01-25 17:52:38
Message-ID: 15611.1453744358@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Sat, Jan 23, 2016 at 11:27 PM, Chapman Flack <chap(at)anastigmatix(dot)net> wrote:
>> What I would have expected would be to allow <Unicode escape value>s
>> for any Unicode codepoint that's representable in the server encoding,
>> whatever encoding that is.

> I don't know anything for sure here, but I wonder if it would make
> validating string literals in non-UTF8 encodings significant more
> costly.

I think it would, and it would likely also require function calls to
loadable functions (at least given the current design whereby encoding
conversions are farmed out to loadable libraries). I do not especially
want the lexer doing that; it will open all sorts of fun questions
involving what we can lex in an already-failed transaction.

It may well be that these issues are surmountable with some sweat,
but it doesn't sound like an easy patch to me. And how big is the
use-case, really?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2016-01-25 17:54:20 Re: 2016-01 Commitfest
Previous Message Robert Haas 2016-01-25 17:49:19 Re: Set search_path + server-prepared statements = cached plan must not change result type