Re: Re: popen and pclose redefinitions causing many warning in Windows build

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: popen and pclose redefinitions causing many warning in Windows build
Date: 2014-05-27 02:24:30
Message-ID: 15514.1401157470@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Tue, May 27, 2014 at 1:39 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> The best alternative I can think of is to use strncmp() to check for
>> whether the head of the string matches "COPY ", and then perform the
>> integer conversion using strtoull() #ifdef HAVE_STRTOULL and strtoul()
>> otherwise.

> What about the attached?

Looks good to me --- pushed.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Shigeru Hanada 2014-05-27 02:47:31 Re: postgres_fdw and connection management
Previous Message Michael Paquier 2014-05-27 01:46:44 Re: Re: popen and pclose redefinitions causing many warning in Windows build