Re: Feature Freeze date for 8.4

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Marko Kreen" <markokr(at)gmail(dot)com>
Cc: josh(at)agliodbs(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Feature Freeze date for 8.4
Date: 2007-10-24 13:24:47
Message-ID: 1508.1193232287@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Marko Kreen" <markokr(at)gmail(dot)com> writes:
> As we seem discussing developement in general, there is one
> obstacle in the way of individual use of DSCMs - context diff
> format as only one accepted.

Well, that's not a hard-and-fast rule, just a preference. At least for
me, unidiff is vastly harder to read than cdiff for anything much beyond
one-line changes. (For one-liners it's great ;-), but beyond that it
intermixes old and new lines too freely.) That's not merely an
impediment to quick review of the patch; if there's any manual
patch-merging to be done, it significantly increases the risk of error.

I don't recall that we've rejected any patches lately just because they
were unidiffs. But I'd be sad if a large fraction of incoming patches
started to be unidiffs.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2007-10-24 13:34:25 Re: Feature Freeze date for 8.4
Previous Message Germán Poó-Caamaño 2007-10-24 13:14:45 Re: Feature Freeze date for 8.4