| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>, pgsql-hackers(at)postgresql(dot)org, KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>, bruce(at)momjian(dot)us, simon(at)2ndQuadrant(dot)com |
| Subject: | Re: Updates of SE-PostgreSQL 8.4devel patches (r1403) |
| Date: | 2009-01-14 14:52:20 |
| Message-ID: | 14998.1231944740@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Martijn van Oosterhout <kleptog(at)svana(dot)org> writes:
> On Tue, Jan 13, 2009 at 10:05:45AM -0300, Alvaro Herrera wrote:
>> pgace.h: you have a bunch of "static inline" functions in here. As far
>> as I know this doesn't work in compilers other than GCC :-(
> Really? C99 requires it and MSVC does support it.
Wrong. What C99 requires is a uselessly cumbersome form of "inline"
that is not compatible with the GCC feature. We did actually implement
C99-compatible inlines in one or two places (in the sorting code IIRC),
but it's not something that I want to put up with on a large scale.
If you ran the current sepostgres patch through an actual C99 compiler,
it would fail.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gerhard Heift | 2009-01-14 14:52:46 | fire trigger for a row without update? |
| Previous Message | Bruce Momjian | 2009-01-14 14:46:19 | Re: Updates of SE-PostgreSQL 8.4devel patches (r1403) |