Re: [sqlsmith] subplan variable reference / unassigned NestLoopParams

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andreas Seltenreich <seltenreich(at)gmx(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [sqlsmith] subplan variable reference / unassigned NestLoopParams
Date: 2015-08-10 21:22:01
Message-ID: 14811.1439241721@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andreas Seltenreich <seltenreich(at)gmx(dot)de> writes:
> Tom Lane writes:
>> Andreas Seltenreich <seltenreich(at)gmx(dot)de> writes:
>>> Tom Lane writes:
>>>> Well, I certainly think all of these represent bugs:
>>>> 3 | ERROR: plan should not reference subplan's variable
>>>> 2 | ERROR: failed to assign all NestLoopParams to plan nodes

>>> These appear to be related. The following query produces the former,
>>> but if you replace the very last reference of provider with the literal
>>> 'bar', it raises the latter error.

>> Fixed that, thanks for the test case!

> I haven't seen the former since your commit, but there recently were
> some instances of the latter. The attached queries all throw the error
> against master at 8752bbb.

Turns out my patch only addressed some cases of the underlying issue.
I've gone back for a second swipe at it; thanks for the continued testing!

BTW, the commit hashes you've been mentioning don't seem to correspond to
anything in the master PG repo ... are you working with modified sources?

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-08-10 21:36:57 Re: linux sparc compile issue
Previous Message Tom Lane 2015-08-10 20:40:31 Re: [COMMITTERS] pgsql: Fix pg_dump to dump shell types.