Re: pgsql: Use quicksort, not replacement selection, for external sorting.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <rhaas(at)postgresql(dot)org>, Peter Geoghegan <pg(at)heroku(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Use quicksort, not replacement selection, for external sorting.
Date: 2016-04-08 14:40:44
Message-ID: 14682.1460126444@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Robert Haas <rhaas(at)postgresql(dot)org> writes:
> Use quicksort, not replacement selection, for external sorting.

This patch evidently broke several of the Windows buildfarm critters,
eg on mastodon:

Build FAILED.
.\src\backend\utils\sort\tuplesort.c(2373): error C2143: syntax error : missing ';' before 'type'
.\src\backend\utils\sort\tuplesort.c(2377): error C2065: 'ntuples' : undeclared identifier
0 Warning(s)
2 Error(s)

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-04-08 14:47:13 Re: pgsql: Use quicksort, not replacement selection, for external sorting.
Previous Message Tom Lane 2016-04-08 13:48:49 Re: pgsql: Phrase full text search.