Re: [PATCHES] fix build on Solaris 10/x86_64 in 64bit mode with Sun Studio 11

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgresql(dot)org, Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>
Cc: Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [PATCHES] fix build on Solaris 10/x86_64 in 64bit mode with Sun Studio 11
Date: 2007-01-10 18:16:23
Message-ID: 14590.1168452983@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc> writes:
> in src/include/port/solaris.h we define it to little endian only for
> __i386 - however in 64bit mode the compiler only defines __amd64 causing
> YTE_ORDER to be undefined.
> The other option would be to use __x86 which is defined on all intel
> architectures.

Shouldn't this use the already-defined __x86_64__ symbol? I assume
that's already defined because otherwise s_lock.h would fail...

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-01-10 18:24:14 Re: [PATCHES] fix build on Solaris 10/x86_64 in 64bit mode with Sun Studio 11
Previous Message Jim C. Nasby 2007-01-10 18:15:47 Re: [HACKERS] [PATCHES] COPY with no WAL, in certain circumstances

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-01-10 18:24:14 Re: [PATCHES] fix build on Solaris 10/x86_64 in 64bit mode with Sun Studio 11
Previous Message Jim C. Nasby 2007-01-10 18:15:47 Re: [HACKERS] [PATCHES] COPY with no WAL, in certain circumstances