| From: | Pavel Kajaba <pkajaba(at)redhat(dot)com> |
|---|---|
| To: | Vladimir Sitnikov <sitnikov(dot)vladimir(at)gmail(dot)com> |
| Cc: | Stephen Nelson <stephen(at)eccostudio(dot)com>, List <pgsql-jdbc(at)postgresql(dot)org>, Pavel Raiskup <praiskup(at)redhat(dot)com>, Dave Cramer <pg(at)fastcrypt(dot)com> |
| Subject: | Re: [pgjdbc] Implement JDBC specs via pre-processor step (#435) |
| Date: | 2016-01-20 11:29:29 |
| Message-ID: | 1453289369.3932.8.camel@redhat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-jdbc |
On Wed, 2016-01-20 at 12:42 +0300, Vladimir Sitnikov wrote:
> > About osgi-enterprise I simply delete content of folder
> > pgjdbc/src/main/java/org/postgresql/osgi and It works without it.
>
> That is a time bomb.
> Why do you think "pgjdbc/src/main/java/org/postgresql/osgi" will ever
> be named like that?
> What if package gets renamed?
>
> Fedora's build scripts should not delete files & folders at random.
> Especially, when you are collaborating with live community.
>
> Vladimir
>
>
Why do you think it's a time bomb?
If someone rename that folder I will try delete something what is not
there and it won't build because osgi end up somewhere else.
Can you think about better solution? Can maven profile say "hey don't
build these files"?
If yes, It would be great. However in case of waffle class which uses
it, would have to be refactored into two (I can't think about different
solution).
Pavel Kajaba
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vladimir Sitnikov | 2016-01-20 11:58:02 | Re: [pgjdbc] Implement JDBC specs via pre-processor step (#435) |
| Previous Message | Vladimir Sitnikov | 2016-01-20 09:42:13 | Re: [pgjdbc] Implement JDBC specs via pre-processor step (#435) |