Re: [GENERAL] Error compiling sepgsql in PG9.1

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Kohei Kaigai <Kohei(dot)Kaigai(at)emea(dot)nec(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [GENERAL] Error compiling sepgsql in PG9.1
Date: 2011-05-24 19:53:19
Message-ID: 14420.1306266799@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> 2011/5/24 Kohei Kaigai <Kohei(dot)Kaigai(at)emea(dot)nec(dot)com>:
>> The attached patch enables to abort configure script when we run it with '--with-selinux'
>> option, but libselinux is older than minimum requirement to SE-PostgreSQL.

> Looks to me like you need to adjust the wording of the error message.
> Maybe "libselinux version 2.0.93 or newer is required", or something like that.

Yeah. Applied with that change.

BTW, it's not helpful to include the diff of the generated configure
script in such patches. The committer will run autoconf for himself,
and from a readability standpoint the generated file is quite useless.

regards, tom lane

In response to

Browse pgsql-general by date

  From Date Subject
Next Message Tom Lane 2011-05-24 23:08:43 Re: Values larger than 1/3 of a buffer page cannot be indexed (hstore)
Previous Message Greg Smith 2011-05-24 18:48:52 Re: [PERFORMANCE] expanding to SAN: which portion best to move

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2011-05-24 19:59:59 Re: [BUGS] BUG #6034: pg_upgrade fails when it should not.
Previous Message Tom Lane 2011-05-24 19:34:17 Re: inconvenient compression options in pg_basebackup