Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Agreed; the attached patch does it that way. (I notice that we have the
> pstate as first arg in many places; I put at the end for
> make_oper_cache_key, together with location. Is there some convention
> to have it as first arg?)
Yes, parser-related functions always have pstate as first arg if they
need it at all. Please follow that convention.
regards, tom lane