Re: compile warnings in CVS

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <nconway(at)klamath(dot)dyndns(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: compile warnings in CVS
Date: 2002-08-18 02:50:55
Message-ID: 14109.1029639055@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I said:
> Another alternative is
> char *fmt = "%c";
> ...
> strftime(..., fmt, ...);
> which I think will probably defeat gcc's check (haven't tried it
> though).

I tried this, and it did shut up the warning in my local copy of gcc.
So I committed it.

> Does anyone want to argue that %c is actually a bad choice?

This is still open to debate if anyone wants to make the case...

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2002-08-18 03:04:02 Re: Open 7.3 items
Previous Message Bruce Momjian 2002-08-18 02:44:16 Re: cvs-tip broken