| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Suraj Kharage <suraj(dot)kharage(at)enterprisedb(dot)com>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, Tels <nospam-pg-abuse(at)bloodgate(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, vignesh C <vignesh21(at)gmail(dot)com> |
| Subject: | Re: documenting the backup manifest file format |
| Date: | 2020-05-15 14:06:52 |
| Message-ID: | 1394fb7f-702b-36f5-0f90-3d8b985fa957@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 5/15/20 9:34 AM, Tom Lane wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> It's a good question. My inclination was to think that GMT would be
>> the clearest thing, but I also didn't realize that the result would
>> thus be inconsistent with backup_label. Not sure what's best here.
>
> I vote for following the backup_label precedent; that's stood for quite
> some years now.
I'd rather keep it GMT. The timestamps in the backup label are purely
informational, but the timestamps in the manifest are useful, e.g. to
set the mtime on a restore to the original value.
Forcing the user to do timezone conversions is prone to error. Some
languages, like C, simply aren't good at it.
Of course, my actual preference is to use epoch time which is easy to
work with and eliminates the possibility of conversion errors. It is
also compact.
Regards,
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-05-15 14:17:19 | Re: documenting the backup manifest file format |
| Previous Message | Tom Lane | 2020-05-15 14:02:38 | Re: ldap tls test fails in some environments |