Re: [PATCHES] HEAD doesn't cope with libraries in non-default

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, decibel(at)decibel(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCHES] HEAD doesn't cope with libraries in non-default
Date: 2005-07-13 17:14:31
Message-ID: 13839.1121274871@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> which looks very odd indeed, especially:

> -L -L../../../src/backend -L../../../src/port -L/c/tcl/lib C:/Perl/lib/CORE -lperl58

Ah, I see the problem:

ifeq ($(PORTNAME), win32)
perl_archlibexp := $(subst \,/,$(perl_archlibexp))
perl_privlibexp := $(subst \,/,$(perl_privlibexp))
perl_embed_ldflags := -L $(perl_archlibexp)/CORE -lperl58
^^^^^^^^^^^^^^^^^^^^^^^^^^
override CPPFLAGS += -DPLPERL_HAVE_UID_GID
endif

The filter hack depends on -L and the following argument to not be
space-separated. We made the no-space assumption before for -L in
LDFLAGS, but not for -L in SHLIB_LINK.

I've removed the space in CVS tip, we'll see where that takes us.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2005-07-13 17:24:17 Re: [PATCHES] HEAD doesn't cope with libraries in non-default
Previous Message Andrew Dunstan 2005-07-13 17:03:44 Re: [PATCHES] HEAD doesn't cope with libraries in non-default

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2005-07-13 17:24:17 Re: [PATCHES] HEAD doesn't cope with libraries in non-default
Previous Message Andrew Dunstan 2005-07-13 17:03:44 Re: [PATCHES] HEAD doesn't cope with libraries in non-default