| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: libpq thread locking during SSL connection start |
| Date: | 2013-08-17 12:22:31 |
| Message-ID: | 1376742151.4080.2.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 2013-08-12 at 10:49 -0400, Stephen Frost wrote:
> > Alternatively, if we want to just print an error message and
> proceed, we
> > should put the strerror based on the return value into the message.
>
> That could certainly be added.
Here is a patch for that. I also adjusted the message wording to be
more in line with project style.
> Should we also be adding an
> error message+strerror in cases where pthread_mutex_unlock() fails for
> some reason?
>
Ideally yes, I think. But it's probably less urgent, because it if
fails the next lock request will probably error?
| Attachment | Content-Type | Size |
|---|---|---|
| pthread-mutex-lock-error.patch | text/x-patch | 1.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2013-08-17 15:55:10 | Re: StrategyGetBuffer optimization, take 2 |
| Previous Message | Huang Bambo | 2013-08-17 11:16:21 | Re: [pgsql-zh-general] Chinese in Postgres |