| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Merlin Moncure <mmoncure(at)gmail(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Commitfest patches mostly assigned ... status |
| Date: | 2008-09-11 21:06:02 |
| Message-ID: | 13741.1221167162@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Merlin Moncure escribi:
>> Alvaro actually performed a review on libpq events. We are waiting on
>> his feedback on our changes (based on his review) and the newly
>> submitted documentation. I'll update the wiki accordingly. I wasn't
>> sure if Alvaro was claiming reviewer status or not. It may be ready
>> to go in as-is unless we draw any new objections.
> The patch looks OK to me as it was the last time I looked at it; maybe
> Tom has more comments, so I decided against just committing it.
I haven't got round to looking at it in this fest. If anyone else wants
to look it over, feel free. I think Josh is overrating the patch's
review difficulty --- anyone who uses libpq a lot could review it,
IMHO. You certainly wouldn't need any backend-internals knowledge.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Merlin Moncure | 2008-09-11 21:14:46 | Re: Commitfest patches mostly assigned ... status |
| Previous Message | Brendan Jurd | 2008-09-11 20:53:55 | Re: Parsing of pg_hba.conf and authentication inconsistencies |