Re: pg_filedump 9.3: checksums (and a few other fixes)

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_filedump 9.3: checksums (and a few other fixes)
Date: 2013-06-10 17:10:12
Message-ID: 1370884212.6384.2.camel@jdavis-laptop
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 2013-06-10 at 11:38 -0400, Tom Lane wrote:
> The thing I'm not too happy about is having to copy the checksum code
> into pg_filedump. We just got rid of the need to do that for the CRC
> code, and here it is coming back again. Can't we rearrange the core
> checksum code similarly to what we did for the CRC stuff recently,
> so that you only need access to a .h file for it?

The CRC implementation is entirely in header files. Do you think we need
to go that far, or is it fine to just put it in libpgport and link that
to pg_filedump?

Regards,
Jeff Davis

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2013-06-10 17:25:22 Re: pg_filedump 9.3: checksums (and a few other fixes)
Previous Message Andrew Dunstan 2013-06-10 17:01:29 Re: JSON and unicode surrogate pairs