Re: reporting reason for certain locks

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: reporting reason for certain locks
Date: 2010-11-25 16:23:42
Message-ID: 13601.1290702222@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> No, what I was suggesting was taking the existing function:
> extern void pgstat_report_waiting(bool waiting);
> ...and instead doing something like this:
> extern void pgstat_report_waiting(char *reason);
> ...and then arrange to pass the reason via the eponymous argument.

The question is how many cycles are we willing to expend on preparing a
reason string that (in approximately 99.9% of the calls) will not be
of any use. It would be much better to avoid doing this and instead
expend the extra work on the inspection side.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2010-11-25 16:24:04 Re: SQL/MED - core functionality
Previous Message Tom Lane 2010-11-25 16:18:23 Re: SQL/MED - core functionality