Skip site navigation (1) Skip section navigation (2)

Re: Rejection of the smallest int8

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: sugita(at)sra(dot)co(dot)jp
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Rejection of the smallest int8
Date: 2001-11-21 15:06:09
Message-ID: 13599.1006355169@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
sugita(at)sra(dot)co(dot)jp writes:
> Attached is a patch to accept the smallest value of int8.

This has been proposed before.  The problem with it is that it's
not portable: the C standard does not specify the direction of rounding
of integer division when the dividend is negative.  So the test
inside the loop that tries to detect overflow would be likely to fail
on some machines.

If you can see a way around that, we're all ears ...

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Dave CramerDate: 2001-11-21 15:21:29
Subject: Benchmarks
Previous:From: Tatsuo IshiiDate: 2001-11-21 15:05:42
Subject: Re: Regression tests need updating...

pgsql-patches by date

Next:From: Tom LaneDate: 2001-11-21 15:12:02
Subject: Re: [PATCHES] Version checking when loading psql
Previous:From: Patrick WelcheDate: 2001-11-21 12:25:55
Subject: Re: [PATCHES] PQescapeBytea documentation patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group