Re: [PATCH] PL/Python: Add spidata to all spiexceptions

From: "Karl O(dot) Pinc" <kop(at)meme(dot)com>
To: Jan Urbański <wulczer(at)wulczer(dot)org>
Cc: Oskari Saarenmaa <os(at)ohmu(dot)fi>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] PL/Python: Add spidata to all spiexceptions
Date: 2013-01-09 19:29:37
Message-ID: 1357759777.6287.4@mofo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 01/09/2013 01:08:39 PM, Jan Urbański wrote:

> > I can see arguments to be made for both sides. I'm asking that you
> > think it through to the extent you deem necessary and make
> > changes or not. At that point it should be ready to send
> > to a committer. (I'll re-test first, if you make any changes.)
>
> Oh my, I have dropped the ball on this one in the worst manner
> possible.
> Sorry!

My fault too. I've been thinking I should write to remind you.

>
> I actually still prefer to keep the signatures of
> PLy_get_spi_sqlerrcode
> and PLy_get_spi_error_data similar, so I'd opt for keeping the patch
> as-is :)

I will send it on to a committer.

Regards,

Karl <kop(at)meme(dot)com>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2013-01-09 19:32:59 Re: Further pg_upgrade analysis for many tables
Previous Message anarazel@anarazel.de 2013-01-09 19:20:35 Re: Re: [PATCH 1/2] Provide a common malloc wrappers and palloc et al. emulation for frontend'ish environs