| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Heikki Linnakangas <heikki(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCHES] [pgsql-patches] Phantom Command IDs,updated patch |
| Date: | 2007-02-09 03:15:26 |
| Message-ID: | 13565.1170990926@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Simon Riggs wrote:
>> Combo is OK, because it's a *combination* of two CommandIds.
>>
>> That means they are ComboCommandIds or CCIs.
> CCI is CommandCounterIncrement to me, so let's not use that
> abbreviation.
Agreed. I looked for a bit at adding a separate typedef ComboCommandId
to be used where a cid was definitely a combo cid, but it didn't seem to
be very useful to do that...
I'm testing the patch currently. I was a bit surprised to find the
without_oid test failing, but it makes sense because I'm using a
MAXALIGN=8 machine. I suppose Heikki tested on MAXALIGN=4.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeremy Drake | 2007-02-09 03:22:58 | patch adding new regexp functions |
| Previous Message | Simon Riggs | 2007-02-09 03:11:18 | Re: [PATCHES] [pgsql-patches] Phantom CommandIDs,updated patch |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeremy Drake | 2007-02-09 03:22:58 | patch adding new regexp functions |
| Previous Message | Simon Riggs | 2007-02-09 03:11:18 | Re: [PATCHES] [pgsql-patches] Phantom CommandIDs,updated patch |