Re: Multiple --table options for other commands

From: "Karl O(dot) Pinc" <kop(at)meme(dot)com>
To: Josh Kupershmidt <schmiddy(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Multiple --table options for other commands
Date: 2012-12-14 04:03:14
Message-ID: 1355457794.26124.11@mofo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12/13/2012 09:24:24 PM, Josh Kupershmidt wrote:
> On Thu, Dec 13, 2012 at 7:24 PM, Karl O. Pinc <kop(at)meme(dot)com> wrote:

> > As a fallback I'd do to the clusterdb, reindexdb, and vacuumdb
> > syntax summaries what was done to the pg_dump and pg_restore
> > syntax summaries. Remove all the detail. This is sucky,
> > and _still_ leaves the reference pages with a syntax summary syntax
> > that differs from regular man pages, but because the text
> > is relatively information free nobody notices.
>
> That should be how the v2 patch has it.

No. The v2 patch does not touch the syntax synopsis.

>
> > My inclination, since you can't make it work
> > and we don't seem to be getting any help here,
> > is to remove all the detail in the syntax summaries,
> > push it through to a committer, and get some feedback that way.
>
> If someone out there feels that the formatting of these commands'
> synopses should look like:
> [ --table | -t table ] ...
>
> and knows how to massage the SGML to get that, I'm happy to
> accommodate the change. Otherwise, I think either the v4 or v2 patch
> should be acceptable.

My brain seems to have turned itself on. I went and (re)read
the docbook manual and was able to come up with this,
which works:

<arg choice="plain" rep="repeat"><arg choice="opt">
<group choice="plain">
<arg choice="plain"><option>--table</option></arg>
<arg choice="plain"><option>-t</option></arg>
</group>
<replaceable>table</replaceable> </arg></arg>

Yay! (indentation et-al aside)

Sorry to be so persnickety, and unhelpful until now.
It seemed like it should be doable, but something
was going wrong between keyboard and chair. I guess
I should be doing this when better rested.

Regards,

Karl <kop(at)meme(dot)com>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2012-12-14 04:05:15 Re: Doc patch, index search_path where it's used to secure functions
Previous Message 李海龙 2012-12-14 04:00:20 Re: I s this a bug of spgist index in a heavy write condition?