Re: In pg_upgrade, remove 'set -x' from test script.

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: In pg_upgrade, remove 'set -x' from test script.
Date: 2012-12-04 04:38:03
Message-ID: 1354595883.30219.4.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 2012-12-03 at 23:26 -0500, Bruce Momjian wrote:
> On Mon, Dec 3, 2012 at 11:24:08PM -0500, Peter Eisentraut wrote:
> > Why was this change made?
>
> I asked Andrew and he had no idea why a 'set -x' would be in the script.
> I ran the script and saw the commands being echoed. Was that
> intentional?

yes

> If so, I can add it back,

please

> but it would be good to add a
> comment as to why it was being used, because Andrew and I had no idea,
> and thought it was a mistake.

Well, it is so you can see what's being run in case you see failures or
odd output. It's usually fairly self-evident what set -x does, but feel
free to comment it.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2012-12-04 04:47:48 Re: In pg_upgrade, remove 'set -x' from test script.
Previous Message Peter Eisentraut 2012-12-04 04:33:27 Re: support for LDAP URLs