Re: pg_dump incorrect output in plaintext mode

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump incorrect output in plaintext mode
Date: 2012-08-28 15:09:34
Message-ID: 1346166424-sup-6923@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Excerpts from Magnus Hagander's message of mar ago 28 08:08:24 -0400 2012:

> In particular, the "restoring data" is obviously completely wrong. But
> AFAICT, the "creating table" and "setting owner" etc are also wrong...
>
> This is because pg_dump calls RestoreArchive(fout).
>
> Do we need to pass down a parameter all the way down the functions to
> tell them if they're restoring or not?

Hmm, but the info is already there, is it not? Isn't AH->ropt->useDB
what you want?

As a translator, I'm not sure that I'm too happy with the idea of having
to translate double the number of strings in pg_dump ...

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kohei KaiGai 2012-08-28 15:18:34 Re: [v9.3] writable foreign tables
Previous Message David Fetter 2012-08-28 15:01:48 Re: [v9.3] writable foreign tables