Re: PL/Python result set slicing broken in Python 3

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Jan Urbański <wulczer(at)wulczer(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PL/Python result set slicing broken in Python 3
Date: 2012-05-10 17:45:00
Message-ID: 1336671900.29567.11.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On lör, 2012-05-05 at 22:45 +0200, Jan Urbański wrote:
> Apparently once you implement PyMappingMethods.mp_subscript you can
> drop PySequenceMethods.sq_slice, but I guess there's no harm in
> keeping it (and I'm not sure it'd work on Python 2.3 with only
> mp_subscript implemented).

Committed this now.

From test coverage reports, I now see that PLy_result_ass_item() is no
longer called. That's probably OK, if assignments are now handled
through the mapping methods. But should we remove the function then?

>
> Do we want to backpatch this? If so, I'd need to produce a version
> that applies to the monolithic plpython.c file from the previous
> releases.

I don't think this should be backpatched.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ants Aasma 2012-05-10 17:45:33 Re: Gsoc2012 idea, tablesample
Previous Message Bruce Momjian 2012-05-10 17:44:23 Re: Draft release notes complete