| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_upgrade relation OID mismatches |
| Date: | 2011-11-25 20:26:24 |
| Message-ID: | 1322252658-sup-2453@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Excerpts from Bruce Momjian's message of vie nov 25 17:05:09 -0300 2011:
> OK, it turns out that exclusion contraints used in pre-9.2 regression
> tests were deleted before the regression tests finished, which means
> they were not tested by me. (This might be a good reason _not_ to have
> the regression tests removing objects before the scripts exit.)
Yeah, I vote for most/all tests keeping their objects instead of
dropping them, where sensible. Also, some tests use a single table name
and create it and drop it just to create it again later with different
properties (I think the alter_table test is like this). We should
avoid that.
--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2011-11-25 20:41:27 | pgsql: Modify pg_dump to use error-free memory allocation macros. This |
| Previous Message | Bruce Momjian | 2011-11-25 20:05:09 | Re: pg_upgrade relation OID mismatches |