Re: pgindent messing up "translator: " comments

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: pgtranslation-translators <pgtranslation-translators(at)postgresql(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgindent messing up "translator: " comments
Date: 2011-09-05 19:41:02
Message-ID: 1315251261-sup-8182@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Excerpts from Alvaro Herrera's message of lun sep 05 16:21:38 -0300 2011:
> I just noticed that this comment got reindented by pgindent
> (xlog.c, line 3226 in REL9_1_STABLE):
> /*
> * translator: First %s represents a recovery.conf parameter name like
> * "recovery_end_command", and the 2nd is the value of that parameter.
> */
> ereport((signaled && failOnSignal) ? FATAL : WARNING,
> (errmsg("%s \"%s\": return code %d", commandName,
> command, rc)));

Actually, after I looked into Git history it turns out that this comment
was introduced in this way; it wasn't pgindent's fault. I checked a
couple of diffs from pgindent runs, and I found no "translator:" comment
reindented destructively. Still, it seems possible that it could happen
someday.

I will fix this one occurence.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-09-05 19:43:32 Re: pgindent messing up "translator: " comments
Previous Message Bruce Momjian 2011-09-05 19:38:46 Re: Macros for time magic values