| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: REGRESS_OPTS default |
| Date: | 2011-08-24 18:30:10 |
| Message-ID: | 1314210611.17771.2.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On tis, 2011-08-23 at 21:17 -0400, Tom Lane wrote:
> There are at least two ways we could fix this: change
> earthdistance/Makefile to do this:
>
> REGRESS_OPTS = --extra-install=contrib/cube --dbname=$(CONTRIB_TESTDB)
>
> or change pgxs.mk to do this:
>
> REGRESS_OPTS += --dbname=$(CONTRIB_TESTDB)
>
> I'm leaning towards the latter as being less prone to mistakes of
> omission. If there's some reason for a pgxs-using makefile to
> override
> the target DB name, it can set CONTRIB_TESTDB instead of messing with
> REGRESS_OPTS.
I like the latter solution as well.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Merlin Moncure | 2011-08-24 18:33:46 | Re: Should I implement DROP INDEX CONCURRENTLY? |
| Previous Message | Daniel Farina | 2011-08-24 18:24:49 | Should I implement DROP INDEX CONCURRENTLY? |