Re: [BUGS] BUG #6034: pg_upgrade fails when it should not.

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tim Uckun <timuckun(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [BUGS] BUG #6034: pg_upgrade fails when it should not.
Date: 2011-06-01 15:40:21
Message-ID: 1306942821.2279.0.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On tis, 2011-05-24 at 15:59 -0400, Bruce Momjian wrote:
> > I think you misread what I wrote, or I misexplained it, but never
> > mind. Matching locale names case-insensitively sounds reasonable to
> > me, unless someone has reason to believe it will blow up.
>
> OK, that's what I needed to hear. I have applied the attached patch,
> but only to 9.1 because of the risk of breakage. (This was only the
> first bug report of this, and we aren't 100% certain about the case
> issue.)

On FreeBSD, locale names appear to be case-sensitive:

$ LC_ALL=en_US.UTF-8 locale charmap
UTF-8

$ LC_ALL=en_US.utf-8 locale charmap
US-ASCII

$ LC_ALL=de_DE.UTF-8 date
Mi 1 Jun 2011 18:22:24 EEST

$ LC_ALL=de_DE.utf-8 date
Wed Jun 1 18:22:47 EEST 2011

So I think that change needs to be reverted.

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Devrim GÜNDÜZ 2011-06-01 16:02:39 Re: BUG #5903: Turkish encoding problem
Previous Message DMS Tech, Sarp 2011-06-01 09:52:21 Re: BUG #5903: Turkish encoding problem

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Golub 2011-06-01 15:43:10 PQdeleteTuple function in libpq
Previous Message Tom Lane 2011-06-01 14:51:57 Re: [COMMITTERS] pgsql: Improve corner cases in pg_ctl's new wait-for-postmaster-startup