| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Rename pg_regress option --multibyte to --encoding |
| Date: | 2011-04-15 20:36:00 |
| Message-ID: | 1302899760.3774.22.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, 2011-04-15 at 12:28 -0400, Andrew Dunstan wrote:
> Yeah, what is the point of this?:
>
> -# Adjust REGRESS_OPTS because we need a UTF8 database
> -REGRESS_OPTS = --dbname=$(CONTRIB_TESTDB) --multibyte=UTF8 --no-locale
> +# We need a UTF8 database +ENCODING = UTF8 +NO_LOCALE = 1
>
>
> Wouldn't it have worked just to change the way we spelled the option
> name in the REGRESS_OPTS line?
It would have, but this way you have the same uniform interface
everywhere. For example, you can easily override the encoding that that
test prescribes.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-04-15 21:46:58 | pgsql: Guard against incoming rowcount estimate of NaN in cost_mergejoi |
| Previous Message | Heikki Linnakangas | 2011-04-15 17:56:19 | pgsql: On Windows, if the encoding implied by locale is not allowed as |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2011-04-15 20:46:48 | Re: regression test client encoding |
| Previous Message | Tom Lane | 2011-04-15 20:09:17 | Re: regression test client encoding |