Re: help: collation support on Windows

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: help: collation support on Windows
Date: 2011-04-07 21:16:48
Message-ID: 1302211008.21369.30.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On fre, 2011-02-25 at 21:32 +0200, Peter Eisentraut wrote:
> According to the online documentation, the APIs are there:
> http://msdn.microsoft.com/en-ca/library/a7cwbx4t.aspx
>
> Now we'd need someone brave try to make it work. The starting point
> would be to define HAVE_LOCALE_T and then make it build. Microsoft has
> all the relevant functions and types with an underscore in front
> (_strcoll_l, etc.), so some extra #defining will probably be necessary.

OK, I got that working now. Patch attached.

> Also, initdb will need to be patched to get a list of OS locales to
> populate the pg_collation catalog with.

That still needs work, but you can run CREATE COLLATION manually.

> Finally, a regression test customized for Windows, but I can help with
> that later.

If you doctor the existing linux test to create appropriately named
collations before running the actual tests, and you hack the
vcregress.pl driver script to run the tests in UTF8 instead of
SQL_ASCII, then all the tests except the Turkish case conversion tests
pass. So looks pretty good so far.

Attachment Content-Type Size
windows-collate.patch text/x-patch 2.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2011-04-07 21:18:00 Re: pg_upgrade bug found!
Previous Message Bruce Momjian 2011-04-07 21:12:51 Re: pg_upgrade bug found!