From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | David Fetter <david(at)fetter(dot)org> |
Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Remove more SGML tabs. |
Date: | 2011-03-24 20:05:44 |
Message-ID: | 1300997144.30823.5.camel@vanquo.pezone.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On tor, 2011-02-10 at 12:58 +0200, Peter Eisentraut wrote:
> There is make check target in doc/src/sgml/ that is supposed to catch
> this. But it's probably hard to remember to run that.
>
> One thing I was thinking of was that we could add a global make
> maintainer-check target (a name I picked up from other projects) which
> would run various source code sanity checks. Besides the SGML tabs
> issue, my favourite would be duplicate_oids. Maybe if we could find a
> third use case, we'd have a quorum for implementing this.
Hah, I found one. There's already a hidden maintainer-check target that
checks the NLS files syntax.
Anyway, here is a small patch that changes the duplicate_oids script to
return a nonzero exit status in case of a problem, and then creates a
global maintainer-check target that checks that and the SGML syntax and
the NLS thing. Other things could be added in the future.
Documentation should be added.
Useful?
Attachment | Content-Type | Size |
---|---|---|
maintainer-check.patch | text/x-patch | 2.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2011-03-24 20:59:22 | pgsql: Edits to 9.1 release notes. |
Previous Message | Tom Lane | 2011-03-24 19:30:09 | pgsql: Clean up handling of COLLATE clauses in index column definitions |
From | Date | Subject | |
---|---|---|---|
Next Message | Radosław Smogura | 2011-03-24 20:27:02 | Re: 2nd Level Buffer Cache |
Previous Message | Jim Nasby | 2011-03-24 19:36:48 | Re: 2nd Level Buffer Cache |