From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Martijn van Oosterhout <kleptog(at)svana(dot)org>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Theory of operation of collation patch |
Date: | 2011-03-10 20:22:47 |
Message-ID: | 1299788567.9423.6.camel@vanquo.pezone.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On tis, 2011-03-08 at 20:52 -0500, Tom Lane wrote:
> I think we should drop <collate clause> from TypeName and just have it
> in columnDef and the expression syntax.
Yes, that sounds better in retrospect. It's easier to see that now that
we see all the cases where it's used and not used.
> This might also ease the
> ambiguity problem that evidently led you to restrict the expression
> production's argument to c_expr.
Maybe, but I seem to recall that I did actually check and concluded that
c_expr covers all cases where <collate clause> is allowed. We could of
course allow more cases, but maybe it's not necessary.
> It would also allow us to meet the
> letter of the spec for <column definition>, in that <collate clause>
> is not required to immediately follow <data type>.
Note that that case is listed under a separate feature. I'm not sure if
it's worth supporting, but if they bothered putting it in it's probably
for compatibility with some existing implementation.
From | Date | Subject | |
---|---|---|---|
Next Message | Dimitri Fontaine | 2011-03-10 20:29:10 | Re: Sync Rep v19 |
Previous Message | Tom Lane | 2011-03-10 20:14:51 | Re: select_common_collation callers way too ready to throw error |