Re: pl/python quoting functions

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Jan Urbański <wulczer(at)wulczer(dot)org>
Cc: Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>, Postgres - Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pl/python quoting functions
Date: 2011-02-23 15:44:01
Message-ID: 1298475841.27343.1.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On ons, 2011-02-23 at 11:26 +0100, Jan Urbański wrote:
> One thing: you removed the conditional pfree from PLy_quote_ident,
> which makes this function leak memory if the actual quoting took
> place, no? Is that leak too small to worry about?

Many functions in PostgreSQL leak memory in this way. It's not worth
worrying about, and certainly not worth violating a called function's
API for it.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Radosław Smogura 2011-02-23 16:07:32 Re: Binary in/out for aclitem
Previous Message Kenneth Marshall 2011-02-23 15:40:30 Re: Correctly producing array literals for prepared statements