| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add ENCODING option to COPY |
| Date: | 2011-02-08 15:42:41 |
| Message-ID: | 1297179761.24949.2.camel@fsopti579.F-Secure.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On fre, 2011-02-04 at 10:47 -0500, Tom Lane wrote:
> The reason that we use quotes in CREATE DATABASE is that encoding
> names aren't assumed to be valid SQL identifiers. If this patch isn't
> following the CREATE DATABASE precedent, it's the patch that's wrong,
> not CREATE DATABASE.
Since encoding names are built-in and therefore well known, and the
names have been aligned with the SQL standard names, which are
identifiers, I don't think this argument is valid (anymore).
It probably shouldn't be changed inconsistently as part of an unrelated
patch, but I think the idea has merit.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2011-02-08 15:42:56 | Re: Re: patch: fix performance problems with repated decomprimation of varlena values in plpgsql |
| Previous Message | Chris Browne | 2011-02-08 15:40:25 | Re: postponing some large patches to 9.2 |